fix(sidebar): menu-bottom-section not showing in mobile

[TheJiahao]

PR #925 moved menu-bottom-section outside main-menu which made it to disappear in mobile. This PR fixes it by moving menu-bottom-section back to main-menu as li and adjusting stylesheets.

Before (desktop)

After (desktop)

Before (mobile)

After (mobile)

[CaiJimmy]

Thanks for the PR!

I think we can simplify the code structure a bit, please check my comments and see if they look good to you.

CSS after the change:

/* Menu style */
#main-menu {
    padding-left: 0;
    list-style: none;
    flex-direction: column;
    overflow-y: auto;
    flex-grow: 1;
    font-size: 1.4rem;
    background-color: var(--card-background);

    box-shadow: var(--shadow-l1);
    display: none;
    margin: 0 calc(var(--container-padding) * -1);

    padding: 30px 30px;

    @include respond(xl) {
        padding: 15px 0;
    }

    &, .menu-bottom-section ol {
        gap: 30px;

        @include respond(xl) {
            gap: 25px;
        }
    }

    &.show {
        display: flex;
    }

    @include respond(md) {
        align-items: flex-end;
        display: flex;
        background-color: transparent;
        padding: 0;
        box-shadow: none;
        margin: 0;
    }

    li {
        position: relative;
        vertical-align: middle;
        padding: 0;

        @include respond(md) {
            width: 100%;
        }

        svg {
            stroke: currentColor;
            stroke-width: 1.33;
            width: 20px;
            height: 20px;
        }

        a {
            height: 100%;
            display: inline-flex;
            align-items: center;
            color: var(--body-text-color);
            gap: var(--menu-icon-separation);
        }

        span {
            flex: 1;
        }

        &.current {
            a {
                color: var(--accent-color);
                font-weight: bold;
            }
        }

        &.menu-bottom-section {
            margin-top: auto;

            ol {
                margin-top: auto;
                display: flex;
                flex-direction: column;
                width: 100%;
                padding-left: 0;
            }
        }
    }
}

[TheJiahao]

The changed CSS seems working. I also removed and combined some redundant styles of .menu-bottom-section ol and #main-menu.

[CaiJimmy]

Thanks!