Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cylinder 3D primitive to Workplane. #858

Merged
merged 6 commits into from
Sep 1, 2021
Merged

Added cylinder 3D primitive to Workplane. #858

merged 6 commits into from
Sep 1, 2021

Conversation

martinbudden
Copy link
Contributor

@martinbudden martinbudden commented Aug 25, 2021 •
edited
Loading

I've added a cylinder 3D primitive to the Workplane, as per item on the roadmap, https://github.com/CadQuery/cadquery/blob/master/doc/roadmap.rst

My first submission to cadquery so a review is very much appreciated, and I'm happy to make any changes requested.

@martinbudden
Copy link
Contributor Author

OK, tests now only failing on

cadquery\occ_impl\exporters\dxf.py:86: error: Module has no attribute "BSplineClosed"
Found 1 error in 1 file (checked 25 source files)
Command exited with code 1

Which was a pre-existing error.

@martinbudden martinbudden changed the title Added cylinder 3D primitive. Added cylinder 3D primitive to Workplane. Aug 25, 2021
@jmwright jmwright mentioned this pull request Aug 27, 2021
Merged
marcus7070
marcus7070 approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@marcus7070 marcus7070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @martinbudden!

cadquery/cq.py Outdated Show resolved Hide resolved
tests/test_cadquery.py Outdated Show resolved Hide resolved
@jmwright jmwright self-requested a review September 1, 2021 15:07
jmwright
jmwright approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinbudden

@jmwright jmwright merged commit 75ea778 into CadQuery:master Sep 1, 2021
@martinbudden martinbudden deleted the cylinder branch September 1, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwright jmwright jmwright approved these changes

@marcus7070 marcus7070 marcus7070 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinbudden @jmwright @marcus7070