Added cylinder 3D primitive to Workplane. - #858
Merged
Merged
Conversation
Contributor
Author
|
OK, tests now only failing on Which was a pre-existing error. |
martinbudden
changed the title
Merged
marcus7070
approved these changes
Aug 31, 2021
marcus7070
left a comment
marcus7070
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks @martinbudden!
jmwright
self-requested a review
September 1, 2021 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a cylinder 3D primitive to the
Workplane, as per item on the roadmap, https://github.com/CadQuery/cadquery/blob/master/doc/roadmap.rstMy first submission to cadquery so a review is very much appreciated, and I'm happy to make any changes requested.