-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fixes (add wedge) #844
Conversation
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 39 39
Lines 9130 9130
Branches 1017 1017
=======================================
Hits 8775 8775
Misses 206 206
Partials 149 149
Continue to review full report at Codecov.
|
Because that section has
at the end, which links to https://cadquery.readthedocs.io/en/latest/apireference.html#id1, which doesn't mention wedges nor cylinders. |
Ok, so we'll need to add the missing a reference to wedge under 3-d Operations at some point. |
Is it a complicated task? Also, what about cylinder? |
No, you can just add it below
I did a search to confirm and there is no analogous method for |
Yes, that looks correct to me. Looks like we're going to have to correct a mypy issue that's probably caused by the update to OCP 7.5.2. I'll try to get to that today or tomorrow. |
@adam-urbanczyk I think it may be the missing OCP 7.5.2 stubs that are keeping mypy from passing in these tests. Could you confirm when you are available? |
Oh, wow, amazing ❤️ We'll wait for it to get merged, if it's ok, and then I'll update the title and content of this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @revolter !
And thank you @adam-urbanczyk for updating my PR 😃 |
No description provided.