Skip to content

More consistent handling of BoundaryBox tolerance#490

Merged
adam-urbanczyk merged 1 commit intoCadQuery:masterfrom
marcus7070:marcus7070/boundboxTol
Oct 24, 2020
Merged

More consistent handling of BoundaryBox tolerance#490
adam-urbanczyk merged 1 commit intoCadQuery:masterfrom
marcus7070:marcus7070/boundboxTol

Conversation

@marcus7070
Copy link
Copy Markdown
Member

I was working on some doc strings for another PR and noticed some inconsistencies in how the tolerances on bounding boxes were handled. This PR changes BoundBox.add tolerance to default to TOL, just like the BoundBox._fromTopoDS method. Also Shape.centerOfBoundBox previously had another different default tolerance that wasn't propagated anyway.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2020

Codecov Report

Merging #490 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files          30       30           
  Lines        5880     5881    +1     
  Branches      626      626           
=======================================
+ Hits         5507     5508    +1     
  Misses        234      234           
  Partials      139      139           
Impacted Files Coverage Δ
cadquery/occ_impl/geom.py 88.96% <ø> (+0.02%) ⬆️
cadquery/occ_impl/shapes.py 90.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b2a10...b59ea20. Read the comment docs.

@jmwright
Copy link
Copy Markdown
Member

Thanks for fixing this @marcus7070

+1 to merge after you've had a chance to take a look @adam-urbanczyk

@adam-urbanczyk adam-urbanczyk self-requested a review October 24, 2020 13:27
@adam-urbanczyk
Copy link
Copy Markdown
Member

Thanks @marcus7070 , looks good!

@adam-urbanczyk adam-urbanczyk merged commit 5b5d8e0 into CadQuery:master Oct 24, 2020
@marcus7070 marcus7070 deleted the marcus7070/boundboxTol branch October 24, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants