Skip to content

More consistent handling of BoundaryBox tolerance #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adam-urbanczyk merged 1 commit into from
Oct 24, 2020
Merged

More consistent handling of BoundaryBox tolerance #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cadquery/occ_impl/geom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@ def __init__(self, bb: Bnd_Box) -> None:
def add(
self,
obj: Union[Tuple[float, float, float], Vector, "BoundBox"],
tol: float = 1e-8,
tol: Optional[float] = None,
) -> "BoundBox":
"""Returns a modified (expanded) bounding box

Expand All @@ -777,6 +777,8 @@ def add(
This bounding box is not changed.
"""

tol = TOL if tol is None else tol # tol = TOL (by default)

tmp = Bnd_Box()
tmp.SetGap(tol)
tmp.Add(self.wrapped)
Expand Down
4 changes: 2 additions & 2 deletions cadquery/occ_impl/shapes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,8 @@ def Center(self) -> Vector:

return Shape.centerOfMass(self)

def CenterOfBoundBox(self, tolerance: float = 0.1) -> Vector:
return self.BoundingBox().center
def CenterOfBoundBox(self, tolerance: Optional[float] = None) -> Vector:
return self.BoundingBox(tolerance=tolerance).center

@staticmethod
def CombinedCenter(objects: Iterable["Shape"]) -> Vector:
Expand Down