Skip to content

Fix tessellate - #420

Merged
jmwright merged 2 commits into
masterfrom
tessellate-fix
Aug 4, 2020
Merged

Fix tessellate#420
jmwright merged 2 commits into
masterfrom
tessellate-fix

Conversation

@adam-urbanczyk

@adam-urbanczyk adam-urbanczyk commented Aug 3, 2020

Copy link
Copy Markdown
Member

Will resolve #416

@codecov

codecov Bot commented Aug 3, 2020

Copy link
Copy Markdown

Codecov Report

Merging #420 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   93.59%   93.59%   -0.01%     
==========================================
  Files          25       25              
  Lines        5291     5306      +15     
  Branches      548      552       +4     
==========================================
+ Hits         4952     4966      +14     
  Misses        215      215              
- Partials      124      125       +1     
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 90.74% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1f8f3...5120642. Read the comment docs.

@adam-urbanczyk
adam-urbanczyk requested a review from jmwright August 4, 2020 18:34

@jmwright jmwright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-urbanczyk Looks, good. Thanks for fixing this.

@jmwright
jmwright merged commit 5f67eb8 into master Aug 4, 2020
@jmwright
jmwright deleted the tessellate-fix branch May 24, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken TJS and AMF exports

2 participants