Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: array ops #96

Merged
merged 10 commits into from
Sep 13, 2024
Merged

feat!: array ops #96

merged 10 commits into from
Sep 13, 2024

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Sep 9, 2024 •
edited
Loading

BREAKING CHANGE: emit_new_array_alloc is replaced by the more general emit_array_op

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.53719% with 105 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@aba5bd0). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/custom/prelude/array.rs 84.09% 6 Missing and 81 partials ⚠️
src/utils/unwrap_builder.rs 84.61% 0 Missing and 8 partials ⚠️
src/utils/array_op_builder.rs 92.63% 0 Missing and 7 partials ⚠️
src/utils/int_op_builder.rs 90.00% 0 Missing and 2 partials ⚠️
src/utils/logic_op_builder.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage        ?   83.20%           
=======================================
  Files           ?       25           
  Lines           ?     3673           
  Branches        ?     3673           
=======================================
  Hits            ?     3056           
  Misses          ?      329           
  Partials        ?      288
Flag Coverage Δ
rust 83.20% <85.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doug-q doug-q marked this pull request as ready for review September 9, 2024 12:47
@doug-q doug-q requested a review from a team as a code owner September 9, 2024 12:47
@doug-q doug-q requested a review from croyzor September 9, 2024 12:47
@doug-q doug-q linked an issue Sep 10, 2024 that may be closed by this pull request
Handle new Array Ops #89
Closed
@doug-q doug-q requested a review from croyzor September 11, 2024 06:43
@doug-q @croyzor
Update src/custom/prelude/array.rs
fecaf05 
Co-authored-by: Craig Roy <croyzor@users.noreply.github.com>
@doug-q doug-q requested a review from croyzor September 13, 2024 10:29
croyzor
croyzor reviewed Sep 13, 2024
View reviewed changes
...tom/prelude/snapshots/hugr_llvm__custom__prelude__array__test__prelude_array_ops@llvm14.snap Outdated
@@ -0,0 +1,104 @@
---
source: src/custom/prelude/array.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what test is this coming from?

@doug-q doug-q added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit ede3f51 Sep 13, 2024
10 checks passed
@doug-q doug-q deleted the doug/array-ops branch September 13, 2024 12:16
@hugrbot hugrbot mentioned this pull request Sep 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 16, 2024
@hugrbot
chore: release v0.5.0 (#98)
1fdc898 
## 🤖 New release
* `hugr-llvm`: 0.4.0 -> 0.5.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.5.0](v0.4.0...v0.5.0) -
2024-09-16

### New Features

- Add emitters for int <-> float/usize conversions
([#94](#94))
- [**breaking**] array ops
([#96](#96))
- Add conversions itobool, ifrombool
([#101](#101))
- Add `tket2` feature and lowerings for `tket2.rotation` extension
([#100](#100))

### Testing

- Add execution test framework
([#97](#97))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@croyzor croyzor croyzor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle new Array Ops
3 participants
@doug-q @codecov-commenter @croyzor