feat: Add tket2 feature and lowerings for tket2.rotation extension
#100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-q
changed the title
tket2 feature and lowerings for angle extension
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 83.31% 83.54% +0.22%
==========================================
Files 25 26 +1
Lines 3758 4016 +258
Branches 3758 4016 +258
==========================================
+ Hits 3131 3355 +224
- Misses 331 343 +12
- Partials 296 318 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cqc-alec
reviewed
Sep 12, 2024
src/custom/angle.rs
Outdated
|
|
||
| /// A codegen extension for the `tket2.angle` extension. | ||
| /// | ||
| /// We lower [ANGLE_CUSTOM_TYPE] to the same [IntType] to which [USIZE_T] is |
There was a problem hiding this comment.
Any reason not to settle on 64-bit integers rather than USIZE_T, so as to be platform-independent?
There was a problem hiding this comment.
The ops are defined to take USIZE_T arguments, so they are not platform independent.
There was a problem hiding this comment.
On reflection the choices are:
- always use USIZE_T: all ops are platform dependent
- use either i64 or a configurable int type: only anew is platform dependent
will change
|
Hi @doug-q could you resolve the conflict in |
doug-q
force-pushed
the
doug/init-angle
branch
from
9d043e8
to
c5be2e7
Compare
doug-q
changed the title
tket2 feature and lowerings for angle extensiontket2 feature and lowerings for tket2.rotation extension
cqc-alec
approved these changes
Sep 16, 2024
src/custom/rotation.rs
Outdated
Comment on lines
98
to
99
| // As we always normalise angles to have a log_denom of | ||
| // angle_width, we do not need the log_denom. |
Comment on lines
+140
to
+153
| // let rads_ok = { | ||
| // let i32_ty = self.0.iw_context().i32_type(); | ||
| // let builder = self.0.builder(); | ||
| // let is_fpclass = get_intrinsic(module, "llvm.is.fpclass", [float_ty.as_basic_type_enum(), i32_ty.as_basic_type_enum()])?; | ||
| // // Here we pick out the following floats: | ||
| // // - bit 0: Signalling Nan | ||
| // // - bit 3: Negative normal | ||
| // // - bit 8: Positive normal | ||
| // let test = i32_ty.const_int((1 << 0) | (1 << 3) | (1 << 8), false); | ||
| // builder | ||
| // .build_call(is_fpclass, &[rads.into(), test.into()], "")? | ||
| // .try_as_basic_value() | ||
| // .left() | ||
| // .ok_or(anyhow!("llvm.is.fpclass has no return value"))? | ||
| // .into_int_value() | ||
| // }; |
There was a problem hiding this comment.
This one is referenced in the comment above. this is the llvm-15 version of the code for later.
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
doug-q
force-pushed
the
doug/init-angle
branch
from
280af9f
to
bcdf0ba
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
## 🤖 New release * `hugr-llvm`: 0.4.0 -> 0.5.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.5.0](v0.4.0...v0.5.0) - 2024-09-16 ### New Features - Add emitters for int <-> float/usize conversions ([#94](#94)) - [**breaking**] array ops ([#96](#96)) - Add conversions itobool, ifrombool ([#101](#101)) - Add `tket2` feature and lowerings for `tket2.rotation` extension ([#100](#100)) ### Testing - Add execution test framework ([#97](#97)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.