Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(video-upload): video upload ui tests #69

Merged
merged 10 commits into from
Oct 31, 2023
Merged

test(video-upload): video upload ui tests #69

merged 10 commits into from
Oct 31, 2023

Conversation

MyStackOverflows
Copy link
Contributor

@MyStackOverflows MyStackOverflows commented Oct 31, 2023 •
edited
Loading

Resovles #65 for video UI

Description of changes:

  • added test for UploadVideoForm component
  • made minor changes to the component itself to improve readability and testability

Motivation for the change:

  • no upload ui tests existed prior to this commit

Notes:

  • coverage is poor because functions aren't being tested, Connor said we'll be doing those with E2E testing later

@MyStackOverflows MyStackOverflows added area/front-end Front-end work test Unit/Integration tests labels Oct 31, 2023
@MyStackOverflows MyStackOverflows self-assigned this Oct 31, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@MyStackOverflows MyStackOverflows linked an issue Oct 31, 2023 that may be closed by this pull request
[Task] Write tests for new front end features #65
Closed
@tthvo tthvo changed the title feat(tests): video upload ui tests test(video-upload): video upload ui tests Oct 31, 2023
tthvo
tthvo previously approved these changes Oct 31, 2023
View reviewed changes
@tthvo
Copy link
Contributor

tthvo commented Oct 31, 2023

Ahh forgot. Please rebase and fix the conflicts.

@tthvo tthvo dismissed their stale review October 31, 2023 04:40

Conflicts not yet solved

tthvo
tthvo approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Haizz, these 3-way merges and making the github UI to show old commit changes too. Wish we can just do squash merge.

@MyStackOverflows
Copy link
Contributor Author

Looks good! Haizz, these 3-way merges and making the github UI to show old commit changes too. Wish we can just do squash merge.

yeah I keep forgetting to pull develop and rebase often

connordoman
connordoman approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@connordoman connordoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad, looks good

@MyStackOverflows MyStackOverflows merged commit 0e5749f into develop Oct 31, 2023
4 checks passed
@tthvo tthvo deleted the gh-65-video-upload-ui-tests branch November 30, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connordoman connordoman connordoman approved these changes

@tthvo tthvo tthvo approved these changes

Assignees

@MyStackOverflows MyStackOverflows

Labels
area/front-end Front-end work test Unit/Integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Write tests for new front end features
3 participants
@MyStackOverflows @tthvo @connordoman