Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Write tests for new front end features #65

Closed
connordoman opened this issue Oct 31, 2023 · 5 comments · Fixed by #69
Closed

[Task] Write tests for new front end features #65

connordoman opened this issue Oct 31, 2023 · 5 comments · Fixed by #69
Assignees
Labels
area/front-end Front-end work chore Refactor, clean up, rename, etc. test Unit/Integration tests

Comments

@connordoman
Copy link
Contributor

New libraries and components added to the front end need unit tests.

@connordoman connordoman added area/front-end Front-end work chore Refactor, clean up, rename, etc. test Unit/Integration tests labels Oct 31, 2023
@connordoman
Copy link
Contributor Author

@MyStackOverflows can you write some tests for the UI you implemented?

@MyStackOverflows
Copy link
Contributor

@MyStackOverflows can you write some tests for the UI you implemented?

yep for sure, do you want that done for tomorrow's presentation and Thuan's talking points/slides?

@connordoman
Copy link
Contributor Author

That would be good. @tthvo are you still able to incorporate new tests into your part of the presentation?

@connordoman
Copy link
Contributor Author

It seems there's an issue with unit testing patternfly components. There is an issue with ES module syntax in Jest. This issue happened specifically with createIcon from patternfly, so it seems testing anything with an icon is not going to work. We will save these for E2E

@tthvo
Copy link
Contributor

tthvo commented Oct 31, 2023

That would be good. @tthvo are you still able to incorporate new tests into your part of the presentation?

Well, for as long as it is a react unit tests, npm run test will cover them :)) I think we just need to show what kind of tests are implemented, rather than what components, or features are being tested. So we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/front-end Front-end work chore Refactor, clean up, rename, etc. test Unit/Integration tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants