BB2-3224: Establish C4DIC feature branch#1205
Merged
jimmyfagan merged 8 commits intofeature/c4dicfrom Jun 13, 2024
Merged
Conversation
JFU-NAVA-PBC
approved these changes
Jun 11, 2024
Contributor
JFU-NAVA-PBC
left a comment
There was a problem hiding this comment.
LGTM
Played with Postman + Local setup, got C4DIC resources as expected.
Great work on demo a multi profile support API
sb-benohe
reviewed
Jun 12, 2024
Collaborator
sb-benohe
left a comment
There was a problem hiding this comment.
@jimmyfagan just a note this general PR looks good, However I did notice some failures in the CI on Jenkins from Flake8 for formatting. We might need to add some of these files to the exclusion list
Contributor
Author
|
Good call @sb-benohe I didn't have pre-commit installed on the repo, that's a good topic to bring back to the team probably to address that topic from retro. Pushed fixes, will check CI and then likely merge what I have into the longer-term feature branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3224
User Story or Bug Summary:
This PR establishes a feature branch that can be used for POCs, demos, sample app implementation, using C4DIC compliant fhir resources.
What Does This PR Do?
This PR builds off of Adrian's C4DIC POC but with some adjustments based on our current plans moving forward for C4DIC with BFD.
What Should Reviewers Watch For?
If you're reviewing this PR, please test by importing the new Postman collection from this page (look for
Blue Button Local Environment (C4DIC)) to verify that the sample C4DIC resources can be retrieved. You will need to generate a new access token that contains the Organization scope to be able to use the Organization endpoint.Also, note that this is a feature branch which will not be deployed to any real environments in this state. This would be re-reviewed before ever being merged to the master branch.
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
What Needs to Be Merged and Deployed Before this PR?
N/A
Any Migrations?
None
Submitter Checklist
I have gone through and verified that...:
READMEupdates and changelog / release notes entries.TODOand/orFIXMEcomments, which include a JIRA ticket ID for any items that require urgent attention.