Fix internal header include paths. #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra leading "CLI/" part of include directives prevents the inclusion of CLI.hpp from a relative directory without an extra -I or /I compiler directive.
Files included with "" should be relative to the header file location first.
samhocevar
force-pushed
the
fix-internal-include-paths
branch
from
335ad70
to
5b2c30b
Compare
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 3724 3724
=========================================
Hits 3724 3724
Continue to review full report at Codecov.
|
|
I think this looks fine to me. Probably can be back ported to 1.9.1. |
henryiii
pushed a commit
that referenced
this pull request
Jun 14, 2020
* Fix internal header include paths. The extra leading "CLI/" part of include directives prevents the inclusion of CLI.hpp from a relative directory without an extra -I or /I compiler directive. * Fix single header generation script. Files included with "" should be relative to the header file location first.
|
Backported. |
nksanthosh
added a commit
to EOSIO/eos
that referenced
this pull request
Aug 3, 2020
This CLI11 update from v1.9.0 to v1.9.1 provides the following improvements: - Support relative inclusion [#475](CLIUtils/CLI11#475) - Fix cases where spaces in paths could break CMake support [#471](CLIUtils/CLI11#471) - Fix an issue with string conversion [#421](CLIUtils/CLI11#421) - Cross-compiling improvement for Conan.io [#430](CLIUtils/CLI11#430) - Fix option group default propagation [#450](CLIUtils/CLI11#450) - Fix for C++20 [#459](CLIUtils/CLI11#459) - Support compiling with RTTI off [#461](CLIUtils/CLI11#461)
7 tasks
dimas1185
pushed a commit
to EOSIO/eos
that referenced
this pull request
Aug 4, 2020
This CLI11 update from v1.9.0 to v1.9.1 provides the following improvements: - Support relative inclusion [#475](CLIUtils/CLI11#475) - Fix cases where spaces in paths could break CMake support [#471](CLIUtils/CLI11#471) - Fix an issue with string conversion [#421](CLIUtils/CLI11#421) - Cross-compiling improvement for Conan.io [#430](CLIUtils/CLI11#430) - Fix option group default propagation [#450](CLIUtils/CLI11#450) - Fix for C++20 [#459](CLIUtils/CLI11#459) - Support compiling with RTTI off [#461](CLIUtils/CLI11#461)
samhocevar
added a commit
to lolengine/ext-cli11
that referenced
this pull request
Feb 21, 2024
The extra leading "CLI/" part of include directives prevents the inclusion of CLI.hpp from a relative directory without an extra -I or /I compiler directive, and makes it harder to make CLI11 part of a larger codebase. This is a regression of CLIUtils#475.
phlptp
pushed a commit
that referenced
this pull request
Mar 11, 2024
The extra leading `"CLI/"` part of include directives prevents the inclusion of `CLI.hpp` from a relative directory without an extra `-I` or `/I` compiler directive, and makes it harder to make CLI11 part of a larger codebase. This is a regression of #475.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra leading "CLI/" part of include directives prevents the inclusion
of CLI.hpp from a relative directory without an extra -I or /I compiler
directive.