try clang 10 #459
Merged
try clang 10 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 3687 3687
=========================================
Hits 3687 3687
Continue to review full report at Codecov.
|
|
@henryiii I added a clang-10 test to the azure_pipelines. the silkeh/clang10 docker doesn't seem to work right for clang10 so I used a builder image from one of our dockerhub repos, If you want that changed let me know. The clang 10 build didn't seem to test the issue so may not be that important right now. |
|
@henryiii whenever you get back into CLI11 this can be reviewed. I think the code changes are good, but let me know what you want to do with the Azure testing changes |
henryiii
approved these changes
May 21, 2020
henryiii
pushed a commit
that referenced
this pull request
Jun 2, 2020
* try clang 10 * use helics-builder clang 10 image * try new image * try again * try different flag addition * try adding cpp20 to visual studio check * try with the latest flag enabled for visual studio 2019 * try the correct c++ flag * remove use of std::result_of * format files
nksanthosh
added a commit
to EOSIO/eos
that referenced
this pull request
Aug 3, 2020
This CLI11 update from v1.9.0 to v1.9.1 provides the following improvements: - Support relative inclusion [#475](CLIUtils/CLI11#475) - Fix cases where spaces in paths could break CMake support [#471](CLIUtils/CLI11#471) - Fix an issue with string conversion [#421](CLIUtils/CLI11#421) - Cross-compiling improvement for Conan.io [#430](CLIUtils/CLI11#430) - Fix option group default propagation [#450](CLIUtils/CLI11#450) - Fix for C++20 [#459](CLIUtils/CLI11#459) - Support compiling with RTTI off [#461](CLIUtils/CLI11#461)
7 tasks
dimas1185
pushed a commit
to EOSIO/eos
that referenced
this pull request
Aug 4, 2020
This CLI11 update from v1.9.0 to v1.9.1 provides the following improvements: - Support relative inclusion [#475](CLIUtils/CLI11#475) - Fix cases where spaces in paths could break CMake support [#471](CLIUtils/CLI11#471) - Fix an issue with string conversion [#421](CLIUtils/CLI11#421) - Cross-compiling improvement for Conan.io [#430](CLIUtils/CLI11#430) - Fix option group default propagation [#450](CLIUtils/CLI11#450) - Fix for C++20 [#459](CLIUtils/CLI11#459) - Support compiling with RTTI off [#461](CLIUtils/CLI11#461)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test build to explore #458.