Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the . to - in species ID, in multifasta and metadata #171

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

jessicarowell
Copy link
Collaborator

@jessicarowell jessicarowell commented Feb 27, 2024

Description

Those dots mess up EVERYTHING. I changed them to hyphens in the multifasta but it's making me feel like getBaseName() should be replaced at some point.

EDIT: I also deleted some extra sample stuff so check that and make sure it's ok.

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • [] Did you check for sensitive data, and remove any?
  • [] If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:

@jessicarowell jessicarowell added the bug Something isn't working label Feb 27, 2024
@jessicarowell jessicarowell self-assigned this Feb 27, 2024
@jessicarowell jessicarowell changed the base branch from master to dev February 27, 2024 23:25
@kyleoconnell kyleoconnell merged commit b246352 into dev Feb 28, 2024
@jessicarowell jessicarowell deleted the correct-bacteria-test-fasta branch March 11, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants