Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Devcontainer to Debian Bullseye and Preinstall Playwright Dependencies #1347

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node
{
"name": "CATcher-development",
"image": "mcr.microsoft.com/devcontainers/typescript-node:1-16",
"image": "mcr.microsoft.com/devcontainers/typescript-node:1-16-bullseye",
"features": {
"ghcr.io/kreemer/features/chrometesting:1": {}
},
Expand All @@ -14,7 +14,8 @@
],
"onCreateCommand": {
"Giving rw permissions to mounted dir": "sudo chown -R node:node ${containerWorkspaceFolder}/*",
"Adding CATcher as upstream": "git remote add upstream https://github.com/CATcher-org/CATcher.git || echo 'already exists'"
"Adding CATcher as upstream": "git remote add upstream https://github.com/CATcher-org/CATcher.git || echo 'already exists'",
"Installing playwright browsers...": "sudo npx playwright install-deps && npx playwright install firefox webkit chromium"
},
// Use 'postCreateCommand' to run commands after the container is created.
// npm with default registry seems to hang frequently, thus a more reliable mirror is used.
Expand Down