Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade Devcontainer to Debian Bullseye and Preinstall Playwright Dependencies #1347

Conversation

Eclipse-Dominator
Copy link
Contributor

Fixes #1346

Description:
This PR addresses the issue of Playwright not being supported in our current devcontainer, which uses Debian Bookworm. To resolve this, we are:

  1. Downgrading the devcontainer base image from Debian Bookworm to Debian Bullseye, which is supported by Playwright.
  2. Preinstalling Playwright's browser dependencies to ensure seamless setup for development and testing workflows.

Changes Included:

  • Updated base image to use debian:bullseye.
  • Added necessary commands to preinstall Playwright's browser dependencies.

Why This Change is Necessary:
Playwright is a critical tool for end-to-end testing in our project, and the lack of support in the current devcontainer is blocking development and testing efforts. This change ensures compatibility and a smoother developer experience.

Proposed Commit message

Preinstall Playwright Dependencies in devcontainer

Playwright dependencies is currently not readily supported in Debian
bookworm which is used by the devcontainer.

As CATcher uses Playwright to do e2e testing, let's
- downgrade the devcontainer to Debian bullseye to support Playwright
- Preinstalls the Playwright testing browser dependencies in the
  container

@Eclipse-Dominator Eclipse-Dominator marked this pull request as ready for review March 20, 2025 07:17
Copy link
Contributor

@Arif-Khalid Arif-Khalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arif-Khalid Arif-Khalid merged commit f6c0edf into CATcher-org:master Mar 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downgrade Devcontainer from Debian Bookworm to Bullseye for Playwright Support
2 participants