Skip to content

Conversation

@QuintillusCFC
Copy link
Member

Closes #307

Closes #309

GitHub Actions isn't the world's most advanced CI product, but I still managed to DRY it out after some research on how to do that. See #309 for more details about that. This currently uses Composite Actions, which seemed like the most appropriate tool for the job, although I'm still not entirely convinced just building for all 3 platforms in one job wouldn't be a superior (if perhaps slightly slower) approach.

@QuintillusCFC
Copy link
Member Author

Okay, I'm marking this as ready. The first commit does the .NET 6.0 part. The remainders are DRYing out the code, there's a commit for each Workflow build. No need to look at each one individually as most got reverted, but if you're curious what was tried, you can see the answer.

Basically it's still not as DRY as I'd like (mainly due to required boilerplate), but my net lines of code is still negative so I think it's good enough for now. My goal here isn't to be an expert on GitHub Actions, and after last month's Serilog tangents, I'd prefer to keep this tangent short.

@QuintillusCFC QuintillusCFC marked this pull request as ready for review July 17, 2022 07:00
@pcen
Copy link
Contributor

pcen commented Jul 21, 2022

looks like I can rebase #204 on this since the approach I took was pretty hacky, but it would be great to get unit tests running in CI

@QuintillusCFC
Copy link
Member Author

Merging after 7+ days with no-review, and self-checking.

@QuintillusCFC QuintillusCFC merged commit a4caaa5 into Development Jul 26, 2022
@QuintillusCFC QuintillusCFC deleted the net6.0-CI-SDK branch July 26, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DRY out the GitHub Actions Configuration Build server can't build with tests at net6.0

3 participants