Save File I/O Tests

[pcen]

Adds integration tests for C7Engine.SaveManager

[pcen]

currently I can't run civ 3, so if someone could add a sav and biq format that would be great

[WildWeazel]

I guess this got overlooked. What do you need, just a random SAV and BIQ added to the project?

[pcen]

Yep, any random SAV and BIQ is fine (or a way to run civ 3 on a MacBook)

[WildWeazel]

@QuintillusCFC do you have a "canonical" test file of either format, or suggestions for making one?

[QuintillusCFC]

The closest I have are the BIQ files listed at https://hg.sr.ht/~adj/civ3_cross_platform_editor/browse/src/test/java/com/civfanatics/civ3/xplatformeditor?rev=tip . The "Custom All.biq" through "Custom Rules and Plyr Data.biq" should cover all the standard expected things for all variants of parts of the BIQ being enabled and not enabled.

Many of the rest (the scenarios) are there primarily for regression testing across a wider range of input scenarios. Some, e.g. the Marla Singer's World Map 1.29f.bic, and Euro.bic, provide coverage for older versions of the format, which I don't believe we have any intention of supporting in C7 (it would require customizations for importing them).

I don't have an equivalent for SAVs. For a variety of sample inputs, one good option would be the GOTM Results at http://gotm.civfanatics.net/results/index.php (make sure you get a Conquests one, the regular GOTM is PTW). I have a submission from COTM 157 (http://gotm.civfanatics.net/download.php?file=Quintillus_COTM157_C3C122_01.SAV) that ought to work well enough.

[QuintillusCFC]

As a side note, the reason that I don't consider my collection "canonical" is that I haven't been thorough about making sure that all the sections of the BIQ that may contain items (but are not required to) actually contain elements. In practice I believe that most do, but there may be a couple edge cases which don't contain items by default lurking that aren't covered by my automated tests and their sample files.

[WildWeazel]

Sounds good for now at least!

[WildWeazel]

oops, accidentally opened this for review. Is anyone still working on it? It's failing CI tests.

[QuintillusCFC]

Other than merging in master to resolve conflicts and seeing it failed, I haven't been, and the rumored return of pcen doesn't appear to have happened yet. I did see it failed the tests, but didn't have the energy to debug it at the time.

[pcen]

we can close this draft, I've made much more progress towards a viable save format / system here #413 and I don't think it's worth investing in github actions for the godot 3.x branch when ultimately we will want a godot 4 docker image