New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy-paste mistake in EcdhTest.java #23

Closed

internot opened this issue Feb 3, 2017 · 1 comment

internot commented Feb 3, 2017 •

edited

Loading

In https://github.com/google/wycheproof/blob/master/java/com/google/security/wycheproof/testcases/EcdhTest.java#L867 in method testDecode() there appears to be a copy-paste mistake:

ECParameterSpec params2 = key1.getParams(); // should be key2

This makes the following asserts to always be true.

The text was updated successfully, but these errors were encountered:

Contributor

thaidn commented Feb 3, 2017

Thanks. I'll send a PR.

thaidn added a commit to thaidn/wycheproof that referenced this issue


          Fix C2SP#23 and C2SP#2

73730d3

thaidn closed this as completed in

62e1bf0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment