Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated input values for primality test #2

Closed
randombit opened this issue Dec 20, 2016 · 2 comments
Closed

Repeated input values for primality test #2

randombit opened this issue Dec 20, 2016 · 2 comments

Comments

@randombit
Copy link

I noticed some values are checked more than once by the primality test, and don't see any obvious reason for the test to repeat for just those inputs. The values 164280218643672633986221, 318665857834031151167461, and 360681321802296925566181 all appear multiple times in the test data in https://github.com/google/wycheproof/blob/master/java/com/google/security/wycheproof/testcases/BigIntegerTest.java

Maybe they can be removed, or maybe there should be a comment explaining the duplication.

Thanks for this great set of tests.
@thaidn
Copy link
Contributor

thaidn commented Dec 20, 2016

Thanks randombit. We'll remove these dups soon.

@thaidn
Copy link
Contributor

thaidn commented Feb 1, 2017

This is fixed with PR #19.

@thaidn thaidn closed this as completed Feb 1, 2017
thaidn added a commit to thaidn/wycheproof that referenced this issue Feb 3, 2017
@thaidn
Fix C2SP#23 and C2SP#2
73730d3
thaidn added a commit that referenced this issue Feb 3, 2017
@thaidn
Fix #23 and #2 (#24)
62e1bf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thaidn @randombit