fix: bound browser upload chunk reads - #720
Merged
Merged
Conversation
Read uploads through one shared limit-plus-one reader so oversized browser chunks are rejected before application-level full allocation. Reuse the reader for flight-log and SRT uploads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #585
Problem
Browser-upload, flight-log, and SRT handlers allocated entire multipart payloads before enforcing configured size limits.
Changes
limit + 1upload readerVerification
await chunk.read()failed the endpoint regression as required3ae55d027676483d10f13695dd658468c608a81e