Skip to content

Comments

slight edit to onboarding TEST#3

Merged
kescobo merged 2 commits intoBonhamLab:mainfrom
danielle-pinto:main
Jun 12, 2025
Merged

slight edit to onboarding TEST#3
kescobo merged 2 commits intoBonhamLab:mainfrom
danielle-pinto:main

Conversation

@danielle-pinto
Copy link
Contributor

@danielle-pinto danielle-pinto commented Jun 12, 2025

Made a fork of lab website and added a small note at the bottom to test making a new PR

Realizing that I pushed my commit to main. I should have made a new branch with this edit. Will remember this for next time.

Copy link
Contributor

@kescobo kescobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're developing from a fork, it works (as you see here), but developing on branches even on forks is better, mostly to build the habit, and in case you forget you're on origin instead of a fork

@kescobo
Copy link
Contributor

kescobo commented Jun 12, 2025

when I make suggestions, you can either commit them directly, or add them to a batch to commit in groups

image

@kescobo
Copy link
Contributor

kescobo commented Jun 12, 2025

Hmm, I think the preview build didn't work because it was from a fork - that might screw with the permissions 🤷

Next time, try doing a branch direct from this repo - you should have write permissions now (if you don't, let me know)

Co-authored-by: Kevin Bonham <kevbonham@gmail.com>
@danielle-pinto
Copy link
Contributor Author

I am happy to add these changes to a branch off the original repo. It looks like I don't have write permissions though...Maybe send the request again? ChatGPT is telling me that if I can't see the settings button, I don't have write permissions on the repository

@kescobo kescobo merged commit d1111a0 into BonhamLab:main Jun 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants