Add FanTV as Zklogin OIDC provider onboarding (MystenLabs#19334)

## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: --------- Co-authored-by: Joy Wang <108701016+joyqvq@users.noreply.github.com>
BoilingOil · Sep 13, 2024 · c413391 · c413391
1 parent 19db7d3
commit c413391
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/crates/sui-config/src/node.rs b/crates/sui-config/src/node.rs
@@ -273,6 +273,7 @@ pub fn default_zklogin_oauth_providers() -> BTreeMap<Chain, BTreeSet<String>> {
         "Playtron".to_string(),
         "Threedos".to_string(),
         "Onefc".to_string(),
+        "FanTV".to_string(),
         "AwsTenant-region:us-east-1-tenant_id:us-east-1_LPSLCkC3A".to_string(), // test tenant in mysten aws
         "AwsTenant-region:us-east-1-tenant_id:us-east-1_qPsZxYqd8".to_string(), // ambrus, external partner
     ]);

diff --git a/crates/sui-swarm-config/tests/snapshots/snapshot_tests__network_config_snapshot_matches.snap b/crates/sui-swarm-config/tests/snapshots/snapshot_tests__network_config_snapshot_matches.snap
@@ -120,6 +120,7 @@ validator_configs:
         - "AwsTenant-region:us-east-1-tenant_id:us-east-1_qPsZxYqd8"
         - Credenza3
         - Facebook
+        - FanTV
         - Google
         - Kakao
         - KarrierOne
@@ -275,6 +276,7 @@ validator_configs:
         - "AwsTenant-region:us-east-1-tenant_id:us-east-1_qPsZxYqd8"
         - Credenza3
         - Facebook
+        - FanTV
         - Google
         - Kakao
         - KarrierOne
@@ -430,6 +432,7 @@ validator_configs:
         - "AwsTenant-region:us-east-1-tenant_id:us-east-1_qPsZxYqd8"
         - Credenza3
         - Facebook
+        - FanTV
         - Google
         - Kakao
         - KarrierOne
@@ -585,6 +588,7 @@ validator_configs:
         - "AwsTenant-region:us-east-1-tenant_id:us-east-1_qPsZxYqd8"
         - Credenza3
         - Facebook
+        - FanTV
         - Google
         - Kakao
         - KarrierOne
@@ -740,6 +744,7 @@ validator_configs:
         - "AwsTenant-region:us-east-1-tenant_id:us-east-1_qPsZxYqd8"
         - Credenza3
         - Facebook
+        - FanTV
         - Google
         - Kakao
         - KarrierOne
@@ -895,6 +900,7 @@ validator_configs:
         - "AwsTenant-region:us-east-1-tenant_id:us-east-1_qPsZxYqd8"
         - Credenza3
         - Facebook
+        - FanTV
         - Google
         - Kakao
         - KarrierOne
@@ -1050,6 +1056,7 @@ validator_configs:
         - "AwsTenant-region:us-east-1-tenant_id:us-east-1_qPsZxYqd8"
         - Credenza3
         - Facebook
+        - FanTV
         - Google
         - Kakao
         - KarrierOne

diff --git a/crates/sui/src/keytool.rs b/crates/sui/src/keytool.rs
@@ -1114,6 +1114,7 @@ impl KeyToolCommand {
                     "https://api.ambrus.studio/callback",
                     &jwt_randomness,
                 )?;
+                // This is only for CLI testing. If frontend apps will be built, no need to add anything here.
                 println!("Visit URL (Google): {url}");
                 println!("Visit URL (Twitch): {url_2}");
                 println!("Visit URL (Facebook): {url_3}");