Add FanTV as Zklogin OIDC provider onboarding #19334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
devan-ko
commented
Sep 12, 2024
crates/sui/src/keytool.rs
Outdated
| &eph_pk_bytes, | ||
| max_epoch, | ||
| "r24bskxyafwwua68et2wmuqeyoa.apps.fantv.world", | ||
| "https://fantv-apis.fantiger.com/v1/oauth2/redirect", |
There was a problem hiding this comment.
There was a problem hiding this comment.
feel free to skip the changes in this file (as whats marked in fastcrypto this is throwing error anyway: https://github.com/MystenLabs/fastcrypto/pull/830/files#diff-81897258a805c29ef8b0319ad0aced2aa3ecef7f654c2489535abb8640ec290dR90)
this was useful for testing in cli, but no need now since you can build frontend for this.
joyqvq
approved these changes
Sep 13, 2024
joyqvq
force-pushed
the
fantv-oidc-onboarding
branch
from
a8ee8d3 to
b3f7f33
Compare
joyqvq
force-pushed
the
fantv-oidc-onboarding
branch
from
0926d64 to
0b56ceb
Compare
suiwombat
pushed a commit
that referenced
this pull request
Sep 16, 2024
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: --------- Co-authored-by: Joy Wang <108701016+joyqvq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
pulling jwk ok on localnet
logs:
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.