fix: gpio_input_get() fails to compile in Arduino-ESP32 parallel mode; replace with REG_READ(GPIO_IN_REG)#3909
Open
skele6011 wants to merge 1 commit intoBodmer:masterfrom
Open
Conversation
…ESP32 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Arduino-ESP32 environments,
gpio_input_get()used inreadByte()fails to compile when using 8-bit parallel mode (
TFT_PARALLEL_8_BIT).This is due to the Arduino-ESP32 core not cleanly exposing every IDF
function. This means
gpio_input_get()is not properly resolved in the Arduinobuild chain, causing a compile error.
Fix
Replace all three calls to
gpio_input_get()withREG_READ(GPIO_IN_REG),which reads the GPIO input register directly at the hardware level with
no dependency on the IDF abstraction layer.
The logic is identical, three reads to allow for bus access time — only
the mechanism changes.
Environment Tested
Notes
The library does not compile at all without this fix in the above environment.
REG_READ(GPIO_IN_REG)is the correct low-level equivalent and works reliably.This fixes issues like the ones here