Removes CMake/common dependency from build system #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes submodules CMake/common - Complete build system based on plain cmake (min version 3.16) - Fixed cross dependency between braynsCommon and braynsEngine
|
retest this please |
|
retest this please |
Adrien4193
reviewed
Nov 22, 2021
engines/ospray/OSPRayModel.cpp
Outdated
| ospRelease(geometry); | ||
| } | ||
| geometry = ospNewGeometry(name); | ||
| // if (geometry) |
There was a problem hiding this comment.
We leave this commented or we can remove it ?
There was a problem hiding this comment.
Removed, thanks!
Adrien4193
reviewed
Nov 22, 2021
tests/CMakeLists.txt
Outdated
|
|
||
| configure_file(paths.h.in ${PROJECT_BINARY_DIR}/tests/paths.h) | ||
|
|
||
| list(APPEND EXCLUDE_FROM_TESTS myPlugin.cpp) | ||
| #list(APPEND CMAKE_MODULE_PATH ${OSPRAY_CMAKE_ROOT}) |
There was a problem hiding this comment.
We leave that commented or we can remove it ?
There was a problem hiding this comment.
Removed, thanks!
Adrien4193
previously approved these changes
Nov 22, 2021
Adrien4193
approved these changes
Nov 22, 2021
NadirRoGue
added a commit
that referenced
this pull request
Dec 14, 2021
- Removes all submodules - Removes CMake/common build system - Complete build system based on plain cmake (min version 3.16) - Fixed cross dependency between braynsCommon and braynsEngine
NadirRoGue
added a commit
that referenced
this pull request
Dec 15, 2021
* Bumped Pillow and websockets version. (#922) * Code cleanup (#923) * Brayns 278 add mock requests in python tests (#924) * Brayns 285 fix logic issue in quanta jpeg stream (#925) * Brayns 286 fix python image method (#928) * Brayns 287 fix python entrypoint methods with one of schema (#929) * Loaders & CircuitExplorer refactoring (#927) * Fixed some typo's (#930) * Update AUTHORS.txt (#931) * Brayns 258 create a proper logging system for brayns (#932) * Frame export improvement and static global objects removal: (#933) * Removes CMake/common dependency from build system (#934) * Removed VRPN plugin and deps. (#935) * Brayns 295 rename brayns json macros to a more appropriate name (#936) * Fixes segfault due to global const std::strings (#939) * Map and unmap framebuffer added. (#940) * Fix entry points variable naming (#941) * Brayns 300 replace free image (#942) * Brayns 308 Code restructure (#943) * Brayns 315 2.0.0 release preparation (#944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bbpteam.epfl.ch/project/issues/browse/BRAYNS-244