Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame export improvement and static global objects removal: #933

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

NadirRoGue
Copy link
Contributor

  • Frame export is now a core feature
  • ODU camera definition is removed, and Frame export uses now the same camera and camera parameter definitions as set/get-camera and set/get-camera-params, allowing to use any kind of camera for frame exporting
  • Fixed bug in NeuronColorHandler based color handlers
  • Removed static global objects in circuit explorer

- Frame export is now a core feature
- ODU camera definition is removed, and Frame export uses now the same camera and camera parameter definitions as set/get-camera and set/get-camera-params, allowing to use any kind of camera for frame exporting
- Fixed bug in NeuronColorHandler based color handlers
- Removed static global objects in circuit explorer
@NadirRoGue NadirRoGue requested a review from Adrien4193 November 5, 2021 12:29
*/
NeuronBuilderTable();

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a personal preference but usually I write it like that:

void registerBuilder(std::unique_ptr<NeuronBuilder> builder) { // register builder }

template<typename T, typename ...Args>
void register(Args &&...args)
{
    registerBuilder(std::make_unique<T>(std::forward<Args>(args)...));
}

Then you can register builders with no default constructors and it is always convenient to have a non-template method to do the registering (and the nasty SFINAE is not required as the code would not compile if T is not a Builder anyway).

@NadirRoGue NadirRoGue merged commit 921266b into develop Nov 5, 2021
@NadirRoGue NadirRoGue deleted the ce_remove_static_global_objects branch November 5, 2021 13:08
NadirRoGue added a commit that referenced this pull request Dec 14, 2021
- Frame export is now a core feature
- ODU camera definition is removed, and Frame export uses now the same camera and camera parameter definitions as set/get-camera and set/get-camera-params, allowing to use any kind of camera for frame exporting
- Fixed bug in NeuronColorHandler based color handlers
- Removed static global objects in circuit explorer
NadirRoGue added a commit that referenced this pull request Dec 15, 2021
* Bumped Pillow and websockets version. (#922)

* Code cleanup (#923)

* Brayns 278 add mock requests in python tests (#924)

* Brayns 285 fix logic issue in quanta jpeg stream (#925)

* Brayns 286 fix python image method (#928)

* Brayns 287 fix python entrypoint methods with one of schema (#929)

* Loaders & CircuitExplorer refactoring (#927)

* Fixed some typo's (#930)

* Update AUTHORS.txt (#931)

* Brayns 258 create a proper logging system for brayns (#932)

* Frame export improvement and static global objects removal: (#933)

* Removes CMake/common dependency from build system (#934)

* Removed VRPN plugin and deps. (#935)

* Brayns 295 rename brayns json macros to a more appropriate name (#936)

* Fixes segfault due to global const std::strings (#939)

* Map and unmap framebuffer added. (#940)

* Fix entry points variable naming (#941)

* Brayns 300 replace free image (#942)

* Brayns 308 Code restructure (#943)

* Brayns 315 2.0.0 release preparation (#944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants