-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OptiX an engine of Brayns #684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice, looking forward to this, especially being able to write your own CUDA renderers. One question: how does one target the Volta GPUs on BB5? |
tribal-tec
reviewed
Jan 29, 2019
tribal-tec
reviewed
Jan 30, 2019
5cc31fe
to
83e013c
Compare
All issues are now fixed. |
tribal-tec
reviewed
Jan 30, 2019
tribal-tec
reviewed
Jan 30, 2019
hernando
reviewed
Jan 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
The OptiX engine now also support using a unique CUDA program for each renderer provided. This enables for instance plugins to add their own OptiX renderers. The OptiX engine now provides two renderers, a basic one and an advanced one.
83e013c
to
02cb163
Compare
Issues fixed. |
tribal-tec
reviewed
Feb 1, 2019
tribal-tec
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OptiX engine now also support using a unique CUDA
program for each renderer provided. This enables for
instance plugins to add their own OptiX renderers.
The OptiX engine now provides two renderers, a basic
one and an advanced one.