Skip to content

Conversation

@danielnordh
Copy link
Contributor

@danielnordh danielnordh commented Oct 14, 2021

As described in #515, updates for Lightning.
Major changes:

  • Rename page (including file and permalink) to: First use (first-use)
  • Update links to work with new name/permalink (images not renamed)
  • Add 'First use' intro paragraph.
  • Shorten 'Create a wallet'
  • Readability tweaks

Note
Due to the filename/permalink change, other PR's may be affected when merging

Preview: https://deploy-preview-525--sad-borg-390916.netlify.app/guide/onboarding/first-use/

@GBKS GBKS added Copy Task is about improving text. Onboarding labels Oct 15, 2021
@GBKS GBKS added this to the Milestone #9 milestone Oct 15, 2021
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 😎 Just a couple of minor recommendations.

I wonder if we need to revise the carousel info at the bottom. For example, the last one about face detection could have an actual button on the screen to enable Face ID. We could also add another screen for initiating the first deposit or purchase (thinking of the mock-ups @sbddesign did for the Phoenix review). That could be a new issue/PR.

@GBKS GBKS linked an issue Oct 15, 2021 that may be closed by this pull request
danielnordh and others added 3 commits October 15, 2021 15:01
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
@sbddesign
Copy link
Collaborator

I wonder if we need to revise the carousel info at the bottom. For example, the last one about face detection could have an actual button on the screen to enable Face ID. We could also add another screen for initiating the first deposit or purchase (thinking of the mock-ups @sbddesign did for the Phoenix review). That could be a new issue/PR.

@GBKS I like the idea of including something like my Phoenix mock-up as it pertains to a LN wallet and forming the first channel. Would that be better suited for the Funding a Wallet page?

Copy link
Collaborator

@sbddesign sbddesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this branch needs to merge in some upstream changes, but otherwise, LGTM @danielnordh 🎉

pavlenex
pavlenex previously approved these changes Oct 18, 2021
Copy link
Contributor

@pavlenex pavlenex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with adding Phoenix's mockups to Funding. I resolved the conflicts and this one only needs @GBKS approval for merge.

@pavlenex pavlenex requested a review from GBKS October 18, 2021 09:15
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
@danielnordh danielnordh dismissed stale reviews from pavlenex via 96d5eb6 October 18, 2021 10:27
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest update from the main branch reverted changes Bosch made when he moved "Getting to know your users" from "Onboarding" to "Designing Bitcoin products".

  • "Getting to know your users" is back in the section overview page
  • "First use" is now the second page in the section - it should be the first
  • The "Creating a new wallet" button on the Onboarding section overview page is a dead link
  • The next button on "Getting to know your users" links now to a different section
  • ...

Not listing it all as there's a bunch of stuff broken now. Please review that latest merge and fix things as required.

Also, once #529 is merged, we can set up the redirect for this page, so old links don't go into nowhere.

@pavlenex
Copy link
Contributor

@GBKS are you referring to this commit e96ad5a?

@GBKS
Copy link
Contributor

GBKS commented Oct 18, 2021

@sbddesign I don't think we need to add the full "first transaction" flow here, but we can show simple examples of extending onboarding beyond static content to include basic settings choices and interactive flows (if they are important for the first use). The "Funding a wallet" page can then cover all the details.

@GBKS
Copy link
Contributor

GBKS commented Oct 18, 2021

@pavlenex that looks like the right one.

…ightning"

This reverts commit e96ad5a, reversing
changes made to 8d2b0ae.
@pavlenex
Copy link
Contributor

I can try to revert it. I'm not sure why it wouldn't merge Bosch's changes. Will see what I did there that may have caused this.

@pavlenex
Copy link
Contributor

I reverted the changes and it's now showing there are no conflicts and that they are even 😕
Screenshot 2021-10-18 at 14 56 21

But it's not even as changes you've mentioned @GBKS are still not there.

@johnsBeharry any idea how we can rebase this one with master?

@pavlenex
Copy link
Contributor

Okay, I realised what the error is. I've selected all commits but the one Bosch did, I am not sure how this happened, could be fat-finger error. Will try to fix it manually now.

@danielnordh
Copy link
Contributor Author

Closing this PR as it was replaced by #531

GBKS added a commit that referenced this pull request Oct 19, 2021
PR #525 renamed the "Creating a wallet" page to "First use" and changed the URL. For that PR, the Jekyll redirect plugin was not available. Now it is, so here's a fix to ensure old links properly redirect to the new page.
@danielnordh danielnordh deleted the feature/onboarding-create-wallet-lightning branch December 2, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ⚡️ content to Onboarding > Creating a new wallet

5 participants