-
Notifications
You must be signed in to change notification settings - Fork 116
Update ⚡️Onboarding - Create a wallet --> First use, for Lightning #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GBKS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 😎 Just a couple of minor recommendations.
I wonder if we need to revise the carousel info at the bottom. For example, the last one about face detection could have an actual button on the screen to enable Face ID. We could also add another screen for initiating the first deposit or purchase (thinking of the mock-ups @sbddesign did for the Phoenix review). That could be a new issue/PR.
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
@GBKS I like the idea of including something like my Phoenix mock-up as it pertains to a LN wallet and forming the first channel. Would that be better suited for the Funding a Wallet page? |
sbddesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this branch needs to merge in some upstream changes, but otherwise, LGTM @danielnordh 🎉
pavlenex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with adding Phoenix's mockups to Funding. I resolved the conflicts and this one only needs @GBKS approval for merge.
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
GBKS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest update from the main branch reverted changes Bosch made when he moved "Getting to know your users" from "Onboarding" to "Designing Bitcoin products".
- "Getting to know your users" is back in the section overview page
- "First use" is now the second page in the section - it should be the first
- The "Creating a new wallet" button on the Onboarding section overview page is a dead link
- The next button on "Getting to know your users" links now to a different section
- ...
Not listing it all as there's a bunch of stuff broken now. Please review that latest merge and fix things as required.
Also, once #529 is merged, we can set up the redirect for this page, so old links don't go into nowhere.
|
@sbddesign I don't think we need to add the full "first transaction" flow here, but we can show simple examples of extending onboarding beyond static content to include basic settings choices and interactive flows (if they are important for the first use). The "Funding a wallet" page can then cover all the details. |
|
@pavlenex that looks like the right one. |
|
I can try to revert it. I'm not sure why it wouldn't merge Bosch's changes. Will see what I did there that may have caused this. |
|
I reverted the changes and it's now showing there are no conflicts and that they are even 😕 But it's not even as changes you've mentioned @GBKS are still not there. @johnsBeharry any idea how we can rebase this one with |
|
Okay, I realised what the error is. I've selected all commits but the one Bosch did, I am not sure how this happened, could be fat-finger error. Will try to fix it manually now. |
|
Closing this PR as it was replaced by #531 |
PR #525 renamed the "Creating a wallet" page to "First use" and changed the URL. For that PR, the Jekyll redirect plugin was not available. Now it is, so here's a fix to ensure old links properly redirect to the new page.

As described in #515, updates for Lightning.
Major changes:
Note
Due to the filename/permalink change, other PR's may be affected when merging
Preview: https://deploy-preview-525--sad-borg-390916.netlify.app/guide/onboarding/first-use/