Fix/pr525 - Update ⚡️Onboarding - Create a wallet --> First use, for Lightning #531
Conversation
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
pavlenex
left a comment
pavlenex
left a comment
There was a problem hiding this comment.
Thanks for a fix @danielnordh.
Since this PR has been reviewed already the only thing to take a look at is now the mergability.
I'll leave @GBKS do the final review.
Much cleaner now without the mess I created. 😬
There was a problem hiding this comment.
Sorry had some last minute suggestions - looks good though!
If we are recommending doing backups post receiving funds is talking about backups on this page that relevant?
Also the next button at the bottom of the Onboarding/Introduction needs to be updated, still says 'Creating a new wallet.'
Co-authored-by: bosch <55287964+Bosch-0@users.noreply.github.com>
|
Link from previous page fixed in 20ba574 |
I think this page strikes an OK balance given it's called 'First use'. Backups and restore are both covered in more detail on later pages, but as they are possible first use activities they are relevant to mention here. |
|
Think this is good to merge now. |
pavlenex
left a comment
pavlenex
left a comment
There was a problem hiding this comment.
LGTM thanks once again for fixing, will merge since the PR already got multiple approvals before we had to re-factor.
This PR replaces #525 due to faulty merge in that PR.
As described in #515, updates for Lightning.
Major changes:
Rename page (including file and permalink) to: First use (first-use)
Update links to work with new name/permalink (images not renamed)
Add 'First use' intro paragraph.
Shorten 'Create a wallet'
Readability tweaks
Preview: https://deploy-preview-531--sad-borg-390916.netlify.app/guide/onboarding/first-use/