Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix a regression in PHP coloring #290

Closed
wants to merge 1 commit into from
Closed

[Bugfix] Fix a regression in PHP coloring #290

wants to merge 1 commit into from

Conversation

JonGarbayo
Copy link
Contributor

@JonGarbayo JonGarbayo commented Mar 11, 2019 •
edited
Loading

Hi @Binaryify!

Again, as the #289, the 7e3c935 commit reintroduced some deleted lines from the pull request #287.
Same description and same result.

@JonGarbayo
fix(syntax): Fix a regression in PHP coloring
8a2f1dc 
The 7e3c935 commit reintroduced again some deleted lines from the pull request #287. So in PHP, "$this" was bicolour ("$" was red, "this" was yellow).
@JonGarbayo JonGarbayo changed the title fix(syntax): Fix a regression in PHP coloring [Bugfix] Fix a regression in PHP coloring Mar 12, 2019
@Binaryify
Copy link
Owner

oh, i ignore your PR and publish a new version and it have some conflicts now, could you fork this repo again and fix that, thanks

@JonGarbayo
Copy link
Contributor Author

Sure! :)

@JonGarbayo JonGarbayo closed this Mar 13, 2019
Binaryify pushed a commit that referenced this pull request Aug 8, 2019
@JonGarbayo
fix(syntax): Fix two regressions in PHP coloring
16cc8e2 
The pull request #292 (the third one to correct #289) deleted the wrong lines. So it didn't fixed anything (unlike the first two, #289 and #290, which were OK).
This commit reverts back these lines, and also fix that red PHP dollar sign with $this.
Binaryify pushed a commit that referenced this pull request Aug 8, 2019
@JonGarbayo
fix(syntax): Fix two regressions in PHP coloring
8495063 
The pull request #292 (the third one to correct #289) deleted the wrong lines. So it didn't fixed anything (unlike the first two, #289 and #290, which were OK).
This commit reverts back these lines, and also fix that red PHP dollar sign with $this.
Binaryify pushed a commit that referenced this pull request Aug 8, 2019
@JonGarbayo
fix(syntax): Fix two regressions in PHP coloring
0206568 
The pull request #292 (the third one to correct #289) deleted the wrong lines. So it didn't fixed anything (unlike the first two, #289 and #290, which were OK).
This commit reverts back these lines, and also fix that red PHP dollar sign with $this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonGarbayo @Binaryify