[Feature] Highlighted language variables (this, super...) #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable.php" entry The "variable" scope is applied for the variable name and the dollar, so no need to specify it.
Variables like "$this" in PHP, or "super" in Java, ES6 JavaScript, TypeScript, JSX, etc. will be highlighted.
…age.this.js,variable.language.this.ts,variable.language.this.jsx,variable.language.this.tsx" entry The new "variable.language" scope is applied for "this" on every supported language. So scoping "this" in JavaScript and TypeScript is no longer useful.
|
great~ |
This was referenced Mar 9, 2019
Binaryify
added a commit
that referenced
this pull request
Aug 8, 2019
[Feature] Highlighted language variables (this, super...)
Binaryify
added a commit
that referenced
this pull request
Aug 8, 2019
[Feature] Highlighted language variables (this, super...)
Binaryify
added a commit
that referenced
this pull request
Aug 8, 2019
[Feature] Highlighted language variables (this, super...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Binaryify!
Thanks for this great theme! I wanted to open an issue, but I decided to improve it myself :)
This is my first pull request ever, please be indulgent.
Motivations
As I work daily with PHP and JavaScript, I was disappointed to see
thishighlighted in yellow in.jsfiles and not$thisin.phpones. Alos, in PHP,parentis highlighted, but notsuperin JavaScript (yes, it's shown italic, but not in other languages like Java).Result
With my modifications, all
variables.languagewill be highlighted in every supported languages. I tested with PHP and JavaScript of course, but also in TypeScript, JSX, C++ and Java.All of them now have
this,superand all that stuff highlighted in yellow :)You can see the result in the following screenshots:
Before
After