Skip to content

fixes improper compartmentalization of project computations #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2020
Merged

fixes improper compartmentalization of project computations #1238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/bap/bap_project.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,13 +398,13 @@ let create
Signal.send Info.got_code code;
Signal.send Info.got_spec spec;
let run k =
let k = KB.(set_package package >>= fun () -> k) in
State.Toplevel.run spec target ~code ~memory file k in
let state = match state with
| Some state -> state
| None ->
let compute_state =
let open KB.Syntax in
set_package package >>= fun () ->
Theory.Unit.for_file file >>= fun unit ->
KB.collect State.slot unit >>= fun state ->
if KB.Domain.is_empty (KB.Slot.domain State.slot) state
Expand Down