fixes improper compartmentalization of project computations #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug reported by @jtpaash (with a nicely reproducible demo). The bug was introduced when we switched to lazy computations so that now symtab and program data structures computations were delayed and could be run in a different state than the disassembly. The main culprit was that those computations were forgetting to properly open the current package to be able to access the objects of the currently disassembled program (they were instead picking those objects from the lastly disassembled program). Fortunately the fix is obvious and simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported by @jtpaash (with a nicely reproducible
demo). The bug was introduced when we switched to lazy computations so
that now symtab and program data structures computations were delayed
and could be run in a different state than the disassembly. The main
culprit was that those computations were forgetting to properly open
the current package to be able to access the objects of the currently
disassembled program (they were instead picking those objects from the
lastly disassembled program). Fortunately the fix is obvious and
simple.