prevents cmdliner from fetching plugins path from environment #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this option is set, and the `-L` or `--plugin-path` option is not used, then plugins path will be fetched from the enviroment variable. However, the plugins library will also look at the same variable and add the same set of paths to the search. Since this variable should be local to the plugins library, and in fact is a part of its interface we should just remove this from the bap-main command line interface.
gitoleg
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this option is set, and the
-Lor--plugin-pathoptionis not used, then plugins path will be fetched from the enviroment
variable. However, the plugins library will also look at the same
variable and add the same set of paths to the search. Since this
variable should be local to the plugins library, and in fact is a
part of its interface we should just remove this from the bap-main
command line interface.
Fixes #1044