Skip to content

Commit 6efba4d

Browse files
authored
prevents cmdliner from fetching plugins path from environment (#1045)
When this option is set, and the `-L` or `--plugin-path` option is not used, then plugins path will be fetched from the enviroment variable. However, the plugins library will also look at the same variable and add the same set of paths to the search. Since this variable should be local to the plugins library, and in fact is a part of its interface we should just remove this from the bap-main command line interface.
1 parent 99ad361 commit 6efba4d

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

lib/bap_main/bap_main.ml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -467,9 +467,8 @@ module Pre = struct
467467

468468
let plugin_locations =
469469
let doc = "Adds folder to the list of plugins search paths" in
470-
let env = Term.env_info ~doc "BAP_PLUGIN_PATH" in
471470
Arg.(value & opt_all string [] &
472-
info ~env ~doc ["L"; "plugin-path"; "load-path"])
471+
info ~doc ["L"; "plugin-path"; "load-path"])
473472

474473
let recipe =
475474
let doc = "Load the specified recipe" in

0 commit comments

Comments
 (0)