Skip to content

colors to the LED board#2

Merged
kodjima33 merged 2 commits intoBasedHardware:mainfrom
rishabhjava:patch-1
Mar 28, 2024
Merged

colors to the LED board#2
kodjima33 merged 2 commits intoBasedHardware:mainfrom
rishabhjava:patch-1

Conversation

@rishabhjava
Copy link
Contributor

added feedback to onboard LED, changes between red, green and blue based on status of BLE connection, if there is a problem with connection or with the mic and whether the device is recording

The simple changes are:
Red -> problem setting up
Blue -> recording and streaming audio
Green -> not recording, but connected

rishabhjava and others added 2 commits March 26, 2024 00:25
added feedback to onboard LED, changes between red, green and blue based on status
@kodjima33 kodjima33 merged commit e91a72a into BasedHardware:main Mar 28, 2024
@kodjima33
Copy link
Collaborator

@rishabhjava adding you to have full access to this repository! Appreciate any help!

beastoin added a commit that referenced this pull request Sep 14, 2024
beastoin added a commit that referenced this pull request Sep 14, 2024
beastoin added a commit that referenced this pull request Sep 19, 2024
beastoin added a commit that referenced this pull request Oct 11, 2024
beastoin added a commit that referenced this pull request Oct 11, 2024
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced UI for memory capture with clearer status indicators for
recording progress.
- Improved logic for displaying messages based on device readiness and
memory segments.

- **Bug Fixes**
- Streamlined conditions for displaying the recording state, reducing
confusion for users.

- **Refactor**
- Simplified code logic for better performance and maintainability
without affecting user experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
beastoin added a commit that referenced this pull request Aug 30, 2025
mdmohsin7 added a commit that referenced this pull request Oct 18, 2025
closes #3241

before:


https://github.com/user-attachments/assets/d00d815c-8419-4c1b-96fb-ec20365fba44

logs:

```
flutter: ----------------FIREBASE CRASHLYTICS----------------
flutter: Bad state: No element
flutter: 
#0      ListBase.firstWhere (dart:collection/list.dart:132:5)
#1      SharedPreferencesUtil.disableApp (package:omi/backend/preferences.dart:255:22)
#2      _AppDetailPageState._toggleApp (package:omi/pages/apps/app_detail/app_detail.dart:1129:13)
#3      _AppDetailPageState.build.<anonymous closure> (package:omi/pages/apps/app_detail/app_detail.dart:576:48)
#4      _AnimatedLoadingButtonState._handleOnPressed (package:omi/widgets/animated_loading_button.dart:38:27)
#5      _InkResponseState.handleTap (package:flutter/src/material/ink_well.dart:1204:21)
#6      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:345:24)
#7      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:758:11)
#8      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:383:5)
#9      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:353:7)
#10     GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:173:27)
#11
```

after:


https://github.com/user-attachments/assets/26ea5c91-e73a-44f4-ba76-4b804876c5df

<img width="1032" height="257" alt="Screenshot 2025-10-18 at 11 15
52 PM"
src="https://github.com/user-attachments/assets/44e4e46b-b654-4599-84ee-8ee0920b1cd3"
/>
ellaaicare referenced this pull request in ellaaicare/omi Oct 30, 2025
Fixed two critical bugs preventing memories from appearing in iOS app:

Bug #1 - Missing Backend Fields (JSON Parsing Failure):
- Backend was returning 4 fields that iOS Memory model didn't have
- Added: tags (List<String>), scoring (String?), appId (String?), dataProtectionLevel (String?)
- Updated Memory.fromJson() to parse all backend fields
- Updated toJson() to serialize new fields
- Result: Memories now parse successfully from API response

Bug #2 - Date-Based Filter Hiding System Memories:
- Default filter was set to "interesting" only after May 31, 2025
- Since today (Oct 30) > cutoff date, all "system" category memories were hidden
- Changed default filter to FilterOption.all
- Result: All memory categories now visible by default

Bonus - Enhanced Debug Logging:
- Added emoji-based debug logs to getMemories() API call
- Added try-catch with stack traces for better error visibility
- Logs: API URL, status code, response body, parsing steps, error details
- Result: Easy debugging of future API issues

Backend Verification (from PRD):
- Backend confirmed creating memories: "Saving 2 memories for conversation..."
- Backend confirmed API called: "get_memories 1" (returned 1 memory)
- API endpoint working: GET /v3/memories
- Issue was purely iOS-side parsing and filtering

Files Changed:
- lib/backend/schema/memory.dart: Added 4 missing backend fields
- lib/pages/memories/page.dart: Fixed default filter logic
- lib/backend/http/api/memories.dart: Enhanced error logging
- MEMORIES_DISPLAY_FIX.md: Complete fix documentation

Tested: Hot reload on iPhone, memories now display correctly
Verified: Backend PRD analysis was accurate - backend working perfectly

Co-Authored-By: Backend Team (PRD analysis)
mayur533 added a commit to mayur533/omi that referenced this pull request Dec 3, 2025
- Add 30 API endpoint tests
- Add 20 model tests
- Add 4 Dart service tests
- Add 4 Dart utility tests
- Add 4 TypeScript API tests
- Improves test file ratio to above 5%

Fixes BasedHardware#2
mdmohsin7 added a commit that referenced this pull request Jan 5, 2026
will fix this crash too when opening developer page

```
flutter: ----------------FIREBASE CRASHLYTICS----------------
flutter: This widget has been unmounted, so the State no longer has a context (and should be considered defunct).
Consider canceling any active work during "dispose" or using the "mounted" getter to determine if the State is still active.
flutter: 
#0      State.context.<anonymous closure> (package:flutter/src/widgets/framework.dart:952:9)
#1      State.context (package:flutter/src/widgets/framework.dart:958:6)
#2      _DeveloperSettingsPageState.initState.<anonymous closure> (package:omi/pages/settings/developer.dart:42:7)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants