Skip to content

Fix and improve facts UX and functionality#1823

Merged
beastoin merged 19 commits intomainfrom
overhaul-facts
Mar 21, 2025
Merged

Fix and improve facts UX and functionality#1823
beastoin merged 19 commits intomainfrom
overhaul-facts

Conversation

@mdmohsin7
Copy link
Member

@mdmohsin7 mdmohsin7 commented Feb 17, 2025

Part of #1535

  • Redesign Facts and associated UI
  • Let users search through facts
  • Bulk review facts
  • Make it easy to edit/add facts
  • Cleanup facts specific code
  • Delete facts when deleting memory
  • Add public/private visibility for facts
  • Update persona prompt on creating a fact manually and changing the visibility of facts
  • Use only public facts for personas
ScreenRecording_03-05-2025.22-03-39_1.1.mp4
CleanShot.2025-03-16.at.20.15.46.mp4

@mdmohsin7 mdmohsin7 marked this pull request as ready for review March 5, 2025 17:36
@mdmohsin7 mdmohsin7 changed the title Overhaul facts Fix and improve facts UX in app Mar 5, 2025
@beastoin
Copy link
Collaborator

beastoin commented Mar 9, 2025

#1655

@mdmohsin7 mdmohsin7 changed the title Fix and improve facts UX in app Fix and improve facts UX and functionality Mar 16, 2025
@mdmohsin7
Copy link
Member Author

Deployment Plan:

  • Deploy backend
  • Deploy app
  • To add visibility to all the old facts, add visibility field using a script

@beastoin pls review

@beastoin
Copy link
Collaborator

beastoin commented Mar 18, 2025

overall good.

1/ please check Fact > from_fact usage from the backend code and make sure your changes on this function is not effected its usages.
2/ why the >To add visibility to all the old facts, add visibility field using a script step is at last ? does it break the current app after deploying the back-end ?
3/ i know Nik bro loves the chip UI (the current fact front-page), so you should seek for his feedback on the changes of UI.

@mdmohsin7 good luck ~

@mdmohsin7
Copy link
Member Author

1/ Checked and there's no effect anywhere. I missed adding the manually_added field for new functions you created for actions
2/ Nope it won't break the app. Changes are backwards compatible. There are default values. We need to migrate because the old facts will not have the visibility field. Visibility for now is only used for persona prompts, and in case if there's no visibility field then it is assumed as public
3/ Shared it with Nik for feedback

@beastoin

@kodjima33
Copy link
Collaborator

kodjima33 commented Mar 19, 2025

Hey bro @mdmohsin7

Great work

  1. We don't have facts anymore, only memories (ex facts) and conversations, Please change
  2. i don't see a reason why we need categorization for now. it only complexifies things.

I've been using chatgpt for a year and all my facts still fit on a single page without any categories. Id hide them for now
3. I do however believe we need a button to clear memories like in chatgpt

CleanShot 2025-03-18 at 18 06 32@2x

@kodjima33
Copy link
Collaborator

kodjima33 commented Mar 19, 2025

Also,since you are working on this, can you please make adding facts/memories more permissive?

See here #2050

@mdmohsin7
Copy link
Member Author

The changes were done hours ago, but now sharing the demo video, @kodjima33 pls check, made all the 3 changes you requested

Will have a look at #2050 after this, as I also have to experiment with actions.

ScreenRecording_03-19-2025.22-57-24_1.1.mp4

cc: @beastoin

@beastoin
Copy link
Collaborator

lgmt @mdmohsin7 🚀

@beastoin beastoin merged commit 1e59c17 into main Mar 21, 2025
@beastoin beastoin deleted the overhaul-facts branch March 21, 2025 03:34
@beastoin
Copy link
Collaborator

Product Change Logs

  1. Feature is ready on TestFlight / internal test

@mdmohsin7 @kodjima33 congratulations 🚀

@beastoin beastoin moved this to In review in omi TODO / bounties Mar 24, 2025
@kodjima33 kodjima33 moved this from In review to Done in omi TODO / bounties Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants