Skip to content

Commit

Permalink
holdings: remove extra titles for some fields in editor
Browse files Browse the repository at this point in the history
Fixes a problem when the title of the fields
location, circulation category and electronic_location
where displayed twice in the holdings editor.

Fixes a problem when librarian can not deselect the
vendor field in the holdings editor.

* Closes rero#1452
* Closes rero#1451

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
  • Loading branch information
Aly Badr committed Nov 19, 2020
1 parent f399f8d commit 478aeac
Showing 1 changed file with 18 additions and 4 deletions.
22 changes: 18 additions & 4 deletions rero_ils/modules/holdings/jsonschemas/holdings/holding-v0.0.1.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,15 @@
],
"properties": {
"$ref": {
"title": "Circulation type URI",
"title": "Circulation category URI",
"type": "string",
"pattern": "^https://ils.rero.ch/api/item_types/.*?$",
"form": {
"remoteOptions": {
"type": "item_types"
},
"templateOptions": {
"label": ""
}
}
}
Expand All @@ -78,7 +81,13 @@
"type": "string",
"pattern": "^https://ils.rero.ch/api/locations/.+?$",
"form": {
"fieldMap": "location"
"fieldMap": "location",
"remoteOptions": {
"type": "locations"
},
"templateOptions": {
"label": ""
}
}
}
}
Expand Down Expand Up @@ -440,14 +449,19 @@
],
"properties": {
"$ref": {
"title": "Vendor URI",
"type": "string",
"pattern": "^https://ils.rero.ch/api/vendors/.*?$",
"form": {
"remoteOptions": {
"type": "vendors"
},
"expressionProperties": {
"templateOptions.required": "false"
},
"remoteOptions": {
"type": "vendors"
"placeholder": "Choose a vendor",
"templateOptions": {
"label": ""
}
}
}
Expand Down

0 comments on commit 478aeac

Please sign in to comment.