Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AudioEngineV2 state playwright tests #16437

Merged

Conversation

docEdub
Copy link
Contributor

@docEdub docEdub commented Apr 2, 2025

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2025

@docEdub docEdub marked this pull request as ready for review April 2, 2025 14:37
@docEdub docEdub enabled auto-merge (squash) April 2, 2025 14:43
@docEdub docEdub requested a review from Copilot April 2, 2025 14:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds state-based Playwright tests for AudioEngineV2 functionality. It introduces configuration changes to include audioV2 tests and adds multiple tests to validate various state transitions of the audio engine.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
playwright.config.ts Added a new configuration block to run tests in the audioV2 directory using a dedicated use definition.
packages/tools/tests/test/audioV2/audioEngineV2.state.test.ts Introduced several tests that simulate user gestures and engine state transitions for AudioEngineV2.

@docEdub docEdub merged commit cba11d1 into BabylonJS:master Apr 2, 2025
16 checks passed
@docEdub docEdub deleted the 250401-add-audioenginev2-playwright-tests branch April 7, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants