Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lines Mesh with Push Material #13457

Merged
merged 2 commits into from
Jan 21, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Lines Mesh with Push Material
  • Loading branch information
sebavan committed Jan 20, 2023
commit 84f0995bf3f98bb58b60449009f14f8e51bba1f8
4 changes: 2 additions & 2 deletions packages/dev/core/src/Meshes/linesMesh.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { Mesh } from "../Meshes/mesh";
import { InstancedMesh } from "../Meshes/instancedMesh";
import { Material } from "../Materials/material";
import { ShaderMaterial } from "../Materials/shaderMaterial";
import type { Effect } from "../Materials/effect";

import "../Shaders/color.fragment";
import "../Shaders/color.vertex";
Expand Down Expand Up @@ -161,11 +162,10 @@ export class LinesMesh extends Mesh {
/**
* @internal
*/
public _bind(): Mesh {
public _bind(_subMesh: SubMesh, colorEffect: Effect): Mesh {
if (!this._geometry) {
return this;
}
const colorEffect = this._lineMaterial.getEffect();

// VBOs
const indexToBind = this.isUnIndexed ? null : this._geometry.getIndexBuffer();
Expand Down