Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lines Mesh with Push Material #13457

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Fix Lines Mesh with Push Material #13457

merged 2 commits into from
Jan 21, 2023

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Jan 20, 2023

https://forum.babylonjs.com/t/using-pbrmaterial-in-linesystem-console-warning-webgl-00002a080233e900/37341/7

The warning was thrown because on the first rendered frame bindForSubMesh has not been called so the effect would be undefined resulting in not bind the index buffer.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 20, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 20, 2023

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG!

@sebavan sebavan merged commit d105658 into BabylonJS:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants