Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bloom blur size is consistent across hardware scaling levels #13286

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Ensure bloom blur size is consistent across hardware scaling levels #13286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Ensure bloom radius size on screen is consistent across different har… 
…dware scaling levels
  • Loading branch information
@kircher1
kircher1 committed Nov 25, 2022
commit 474f35debe13301e8910c5780b730b594b01df47
17 changes: 10 additions & 7 deletions packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/defaultRenderingPipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export class DefaultRenderingPipeline extends PostProcessRenderPipeline implemen
private _rebuildBloom() {
// recreate bloom and dispose old as this setting is not dynamic
const oldBloom = this.bloom;
this.bloom = new BloomEffect(this._scene, this.bloomScale, this._bloomWeight, this.bloomKernel, this._defaultPipelineTextureType, false);
this.bloom = new BloomEffect(this._scene, this.bloomScale, this._bloomWeight, this.bloomKernel / this._hardwareScaleLevel, this._defaultPipelineTextureType, false);
this.bloom.threshold = oldBloom.threshold;
for (let i = 0; i < this._cameras.length; i++) {
oldBloom.disposeEffects(this._cameras[i]);
Expand Down Expand Up @@ -454,6 +454,7 @@ export class DefaultRenderingPipeline extends PostProcessRenderPipeline implemen
scene.postProcessRenderPipelineManager.addPipeline(this);

const engine = this._scene.getEngine();

// Create post processes before hand so they can be modified before enabled.
// Block compilation flag is set to true to avoid compilation prior to use, these will be updated on first use in build pipeline.
this.sharpen = new SharpenPostProcess("sharpen", 1.0, null, Texture.BILINEAR_SAMPLINGMODE, engine, false, this._defaultPipelineTextureType, true);
Expand All @@ -468,7 +469,14 @@ export class DefaultRenderingPipeline extends PostProcessRenderPipeline implemen

this.depthOfField = new DepthOfFieldEffect(this._scene, null, this._depthOfFieldBlurLevel, this._defaultPipelineTextureType, true);

this.bloom = new BloomEffect(this._scene, this._bloomScale, this._bloomWeight, this.bloomKernel, this._defaultPipelineTextureType, true);
// To keep the bloom sizes consistent across different display densities, factor in the hardware scaling level.
this._hardwareScaleLevel = engine.getHardwareScalingLevel();
this._resizeObserver = engine.onResizeObservable.add(() => {
this._hardwareScaleLevel = engine.getHardwareScalingLevel();
this.bloomKernel = this._bloomKernel;
});

this.bloom = new BloomEffect(this._scene, this._bloomScale, this._bloomWeight, this.bloomKernel / this._hardwareScaleLevel, this._defaultPipelineTextureType, true);

this.chromaticAberration = new ChromaticAberrationPostProcess(
"ChromaticAberration",
Expand Down Expand Up @@ -501,11 +509,6 @@ export class DefaultRenderingPipeline extends PostProcessRenderPipeline implemen
true
);

this._resizeObserver = engine.onResizeObservable.add(() => {
this._hardwareScaleLevel = engine.getHardwareScalingLevel();
this.bloomKernel = this._bloomKernel;
});

this._imageProcessingConfigurationObserver = this._scene.imageProcessingConfiguration.onUpdateParameters.add(() => {
this.bloom._downscale._exposure = this._scene.imageProcessingConfiguration.exposure;

Expand Down