Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bloom blur size is consistent across hardware scaling levels #13286

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

kircher1
Copy link
Contributor

The default rendering pipeline seemed like it was attempting to normalize the bloom blur kernel by the hardware scaling level, but it only took it into account when the hardware scaling level changes at runtime and didn't factor it in upon creation or when constructing the bloom effect itself.

I think the idea to keep the bloom size consistent across different hardware scaling levels is the right idea, but the code needs to change a bit to account for this.

To show the difference:

Starting hardware scale Before After
1x image image
2x image image

Notice the bottom left before image of 2x scale has a bloom that is much wider and blurrier, rather than matching the 1x scale.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebavan sebavan merged commit e733a2c into BabylonJS:master Nov 25, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Ensure bloom blur size is consistent across hardware scaling levels

Former-commit-id: 5683b95f5c6bd5a4d5ef49984f9ed38d0c8631bb
@kircher1 kircher1 deleted the hardware-scaling-level-bloom branch September 2, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants