Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test babylon mesh lod 2 #13234

Merged
merged 14 commits into from
Nov 14, 2022
Merged

Test babylon mesh lod 2 #13234

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ca554ce
(style) Mesh.LOD. Fix style guide
Dok11 Nov 13, 2022
4fd2bc7
(test) Mesh.getLOD. Test case to check BoundingSphere argument
Dok11 Nov 13, 2022
4889396
(test) Mesh.getLOD. Test case to check getLOD without LODs
Dok11 Nov 13, 2022
0625330
(fix) Mesh.getLOD. Simplify the bSphere definition
Dok11 Nov 13, 2022
35e6dd9
(fix) Mesh.getLOD. Remove the redundant intermediate variable
Dok11 Nov 13, 2022
7ea6e51
(test) Mesh.getLOD. Check chaining operator
Dok11 Nov 13, 2022
06697c2
(test) Mesh.removeLODLevel. Basic test to check the function
Dok11 Nov 13, 2022
3e6de7a
(test) Mesh.removeLODLevel. Add expect to check LOD level count
Dok11 Nov 13, 2022
3eb0a10
(fix) Mesh.removeLODLevel. Make argument nullable as it presented in doc
Dok11 Nov 13, 2022
c402521
(test) Mesh.removeLODLevel. Test function to remove null from LOD
Dok11 Nov 13, 2022
0498d5c
(test) Mesh.removeLODLevel. Remove the unnecessary camera from test code
Dok11 Nov 13, 2022
ce68c47
(test) Mesh.getLODLevelAtDistance. Add basic test case
Dok11 Nov 13, 2022
0e5c0be
(test) Mesh.LOD. Refactoring test code
Dok11 Nov 13, 2022
c2cc810
(test) Mesh.addLODLevel. Add specified test case to check twice adding
Dok11 Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
(test) Mesh.removeLODLevel. Remove the unnecessary camera from test code
  • Loading branch information
@Dok11
Dok11 committed Nov 13, 2022
commit 0498d5c73349d6a0473708c87f088c72944bc524
4 changes: 0 additions & 4 deletions packages/dev/core/test/unit/Meshes/babylon.mesh.lod.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,6 @@ describe("Babylon Mesh Levels of Details", () => {
describe("removeLODLevel", () => {
let scene: Scene;
let cameraArc: ArcRotateCamera;
let cameraOrthographic: ArcRotateCamera;

let knot0: Mesh;
let knot1: Mesh;
Expand All @@ -291,9 +290,6 @@ describe("Babylon Mesh Levels of Details", () => {

cameraArc = new ArcRotateCamera("Camera", 0, 0, 5, new Vector3(0, 0, 0), scene);

cameraOrthographic = new ArcRotateCamera("Camera", 0, 0, 5, new Vector3(0, 0, 0), scene);
cameraOrthographic.mode = Camera.ORTHOGRAPHIC_CAMERA;

knot0 = MeshBuilder.CreateTorusKnot(
"Knot0",
{
Expand Down