Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test babylon mesh lod 2 #13234

Merged
merged 14 commits into from
Nov 14, 2022
Merged

Conversation

Dok11
Copy link
Contributor

@Dok11 Dok11 commented Nov 13, 2022

Hi!

Here I found some trouble with removeLODLevel method — in the doc presented example where we can remove null from LOD, but the method didn't have ability to do it.

https://doc.babylonjs.com/features/featuresDeepDive/mesh/LOD

image


Also I did not found the way how to reach this code part:
image

It's necessary? In which cases?


And one thing more. I dont know is it trouble or not, but the addLODLevel method allows to add multiple meshes to the same distance. There are no any checks to this case.
Probably have reaseon to add Logger Warn at least?

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 0049371 into BabylonJS:master Nov 14, 2022
@sebavan
Copy link
Member

sebavan commented Nov 14, 2022

Thanks a lot @Dok11

RaananW pushed a commit that referenced this pull request Dec 9, 2022
Test babylon mesh lod 2

Former-commit-id: 594b70b558abb1abbbe5030619675e62003c98a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants