Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics,scene Bug fixes #12374

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Physics,scene Bug fixes #12374

merged 2 commits into from
Apr 11, 2022

Conversation

CedricGuillemet
Copy link
Contributor

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12374/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12374/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12374/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12374/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12374/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12374/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12374/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12374/merge#BCU1XR#0

@deltakosh
Copy link
Contributor

@CedricGuillemet When is skipPointerDownPicking supposed to be true?

@CedricGuillemet
Copy link
Contributor Author

@deltakosh any time you don't need (CPU intensive) picking : game, viewer, demo, ...
For example, on native I drop from 60FPS to 8FPS with space demo. picking in non-JIT is very expensive. It's also expensive on the web.
another case here : BabylonJS/BabylonReactNative#387

@deltakosh
Copy link
Contributor

Makes sense!

@deltakosh deltakosh merged commit 1118912 into BabylonJS:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants