-
Notifications
You must be signed in to change notification settings - Fork 15
Program managers can now see background check #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Team/celts into backgroundCheck
…eDevTeam/celts into backgroundCheck
…d, passed, failed
…eDevTeam/celts into backgroundCheck
JohnCox2211
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JohnCox2211
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new interface looks a lot better, good work. There is some repetitive code logic that should be able to be streamlined with some repeating for loops for both {% for bgType in backgroundTypes %} and {% for bgStatus in allBackgroundHistory[bgType.id] %}.
JohnCox2211
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, my comments have been resolved, the functionality is there, and the user interface looks great.
Karina-Agliullova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Brian's changes, everything works well and looks clean!

Issue Description
Fixes #1634
Changes
Testing