Skip to content

Conversation

@bakobagassas
Copy link
Contributor

Issue Description

Fixes #1634

  • Program managers should have the ability to see volunteers' and any other students' background check

Changes

  • changes the view permission for the background check for the program managers aka student staff
image

Testing

  • Log in as "Student Staff Neillz"
  • Go to "Student search"
  • Search for any student
  • You should be able to see the background check of that person

Copy link
Contributor

@JohnCox2211 JohnCox2211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a display change for when there are no background checks. Just having description as a header with nothing below I would say is not optimal.

What I am referring to:
image

Copy link
Contributor

@JohnCox2211 JohnCox2211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new interface looks a lot better, good work. There is some repetitive code logic that should be able to be streamlined with some repeating for loops for both {% for bgType in backgroundTypes %} and {% for bgStatus in allBackgroundHistory[bgType.id] %}.

JohnCox2211
JohnCox2211 previously approved these changes Nov 19, 2025
Copy link
Contributor

@JohnCox2211 JohnCox2211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, my comments have been resolved, the functionality is there, and the user interface looks great.

Copy link
Contributor

@Karina-Agliullova Karina-Agliullova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Brian's changes, everything works well and looks clean!

@BrianRamsay BrianRamsay merged commit fc86acd into development Nov 24, 2025
0 of 4 checks passed
@BrianRamsay BrianRamsay deleted the backgroundCheck branch November 24, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Program Managers to see the Background check

6 participants