Dietary restrictions volunteer details 1450 #1516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue again and edited conditional statement in html file.
BrianRamsay
previously requested changes
Jun 17, 2025
Contributor
BrianRamsay
left a comment
BrianRamsay
left a comment
There was a problem hiding this comment.
-
This isn't exactly what we are needing. We need to see a distinction between a volunteer having no dietary restrictions, and an empty field because they have not filled it out. Currently, both cases will show "None specified", which is the same as having it empty for both cases.
-
Your description mentions that you changed the field in the database to not allow nulls, but I don't see that file in the pull request.
-
I know the ticket asked for it, but I don't think it's necessary to have "Dietary Restriction(s)". We can put it back the way it was, "Dietary Restrictions". The plural is fine in all cases.
…sappears a checkbox
…tofills with 'No dietary restrictions'
…rictions and fixed the display for when the user unchecks the diet restriction box
BrianRamsay
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes #1450
Changes
-Changed dietRestriction = TextField(null=True) in minor.py file to dietRestriction = TextField(null=False) to change the conditional statement for a null input. Now the volunteer details page shows "Not specified" if the dietRestriction is null.
Testing