-
Notifications
You must be signed in to change notification settings - Fork 15
Accordion design 1453 #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion design 1453 #1507
Conversation
updated accordion displays
|
Currently redesigning the 'Edit Volunteer Information' accordion into a modal |
We are done with all the new designs. |
|
We are done with the new designs that Scott suggested. |
|
In your Edit Volunteer Information Modal, there is an issue with Dietary Restrictions. Add a save button so people can save it whenever they input information in that box. |
|
In the first accordion, you are referring to the admin being interested in the minor. This should only be available for students, as they are the ones who can be interested in a minor. If an admin has the ability to indicate interest for a student, then the language should be changed to refer to a student and not to an admin |
BrianRamsay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The buttons should be a consistent color. Right now we are using blue, gray, and yellow. Maybe all Yellow? That's generally our 'action' color that isn't a save, cancel, or main action.
BrianRamsay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have the same or similar behavior for dietary restrictions in the modal as the functionality we added in #1516, so that it's clear when a student has no restrictions vs they just haven't looked at it.
Issue Description
Fixes #1453
Changes
Testing
Before

After


